refactor: wave e naming conventions - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave E (final) of the architecture-hardening plan: brand constructors renamed toUserId/toProjectId/toThreadId/toAgentRunId (12 rename-imports deleted, raw casts routed through constructors), error-code grammar normalized to with the closed union + RETRIABLE_CODES intact, discriminant convention applied (type=wire, kind=in-process), the agent-core naming island fixed (~30 schema casings) with capability-first tool ids (code_run, search_scrape scheme — SKILL.md bodies updated, manifest metadata unchanged), Row/Record violations fixed, success/ok + boolean prefixes + -support standardization + controller filename convention + header casing unified, Zod v4 migration (zero .strict() remaining), the House Conventions section codified in AGENTS.md + CLAUDE.md, cruiser rules re-proven firing post-renames, knip zero. All renames atomic per the pre-launch no-legacy directive. Net −1,500 LOC. Gates green including 19/19 build, worker dry-runs, and skills bundle.